This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Refactor all (demo) runtime modules to use new storage #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet complete but 75% there.
Merged
rphmeier
reviewed
Mar 19, 2018
| @@ -80,40 +80,37 @@ impl GenesisConfig { | |||
| pub fn genesis_map(&self) -> HashMap<Vec<u8>, Vec<u8>> { | |||
| let wasm_runtime = include_bytes!("../wasm/genesis.wasm").to_vec(); | |||
| vec![ | |||
| (&session::SESSION_LENGTH[..], vec![].and(&self.session_length)), | |||
| (&session::VALIDATOR_COUNT[..], vec![].and(&(self.validators.len() as u32))), | |||
| (session::SessionLength::key(), vec![].and(&self.session_length)), | |||
rphmeier
reviewed
Mar 19, 2018
| @@ -122,58 +122,77 @@ pub fn put_raw(key: &[u8], value: &[u8]) { | |||
| runtime_io::set_storage(&twox_128(key)[..], value) | |||
| } | |||
|
|
|||
| struct RuntimeStorage; | |||
| pub struct RuntimeStorage; | |||
There was a problem hiding this comment.
doe it need to be pub? should have docs if so
There was a problem hiding this comment.
yup it's needed for the macro
rphmeier
reviewed
Mar 19, 2018
| @@ -48,46 +48,78 @@ | |||
|
|
|||
| use codec; | |||
| use rstd::vec::Vec; | |||
| pub use rstd::borrow::Borrow; | |||
rphmeier
reviewed
Mar 19, 2018
| /// Load the bytes of a key from storage. Can panic if the type is incorrect. | ||
| fn load<T: codec::Slicable>(&self, key: &[u8]) -> Option<T>; | ||
| fn require<T: codec::Slicable>(&self, key: &[u8]) -> T { self.get(key).expect("Required values must be in storage") } |
There was a problem hiding this comment.
doc string should specify that it panics if it's not there
rphmeier
reviewed
Mar 19, 2018
| self.kill(key); | ||
| value | ||
| } | ||
|
|
||
| /// Take a value from storage, deleting it after reading. | ||
| fn seize<T: codec::Slicable>(&self, key: &[u8]) -> T { self.take(key).expect("Required values must be in storage") } |
There was a problem hiding this comment.
take/seize is confusing. take_required?
rphmeier
reviewed
Mar 19, 2018
| (($($vis:tt)*) $name: ident: $key: expr => $ty:ty) => { | ||
| (($($vis:tt)*) ($get_fn:ident) ($gettype:ty) ($getter:ident) ($taker:ident) $name:ident : $key:expr => $ty:ty) => { | ||
| __storage_items_internal!{ ($($vis)*) () ($gettype) ($getter) ($taker) $name : $key => $ty } | ||
| pub fn $get_fn() -> $gettype { <$name as $crate::storage::generator::StorageValue<$ty>> :: get(&$crate::storage::RuntimeStorage) } |
There was a problem hiding this comment.
tightly coupling the macro to RuntimeStorage (which is useless outside of runtime context) isn't helpful.
We have a $name::get() function anyway via the parent storage module.
There was a problem hiding this comment.
yeah but it's crappy to have half of the getters use the idiomatic lower_case_function() and half using PascalCaseName::get(). you need to guess which is which.
There was a problem hiding this comment.
if there's a better way of doing this, then happy to go with it, but i don't see it.
There was a problem hiding this comment.
fine for now, although I dislike the coupling. maybe could have a separate macro for generating the getter
rphmeier
approved these changes
Mar 19, 2018
rphmeier
added
A8-looksgood
and removed
A0-please_review
tomaka
pushed a commit
to tomaka/polkadot
that referenced
this pull request
Feb 6, 2019
* bump substrate version * fix polkadot-collator
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Rebuild runtime * Remove invalid value from chainspec (paritytech#68) * service: use grandpa block import for locally sealed aura blocks (paritytech#85) * bump version to v0.3.1 * Update lock file. * limit number of transactions when building blocks (paritytech#91) * Update to latest Substrate * Bump to 0.3.2 * Actually bump. * v0.3.2 (paritytech#98) * bump substrate version * fix polkadot-collator * point to alexander-backports of substrate * bump version * cli: fix node shutdown (paritytech#100) * update to latest substrate, change to v0.3.4 * update to latest substrate, bump version to 0.3.5 * v0.3.6 * try to build on every v0.3 commit and update alexander-backports * bump to v0.3.7 * bump to 0.3.8 * Bump to 0.3.9: network and pruning improvements * Bump to 0.3.10: reduce network bandwidth usage * Use libp2p-kad 0.3.2 (paritytech#122) * Bump libp2p-identify to 0.3.1 (paritytech#123) * Bump to 0.3.12 (paritytech#127) * Update Substrate again (paritytech#128) * update substrate and bump version to v0.3.13 * bump version to v0.3.14: fix --reserved-nodes * add a manually curated grandpa module (paritytech#136) * updating v0.3 to use substrate v0.10 (paritytech#146) * updating to latest substrate v0.10 * better handling of outer poll * nit * fix tests * remove comment * reduce indentation * use self.poll * bring oneshot into scope * spaces * wrap * remove match * wrap * Update primitives/Cargo.toml Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com> * Update runtime/wasm/Cargo.toml Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com> * Update runtime/wasm/Cargo.toml Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com> * Update test-parachains/adder/collator/src/main.rs Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com> * indent * add paranthese * config: fix wrong ip for alexander bootnode (paritytech#161) * fix curated-grandpa and rebuild wasm (paritytech#162) * [v0.3] Integrates new gossip system into Polkadot (paritytech#166) * new gossip validation in network * integrate new gossip into service * network: guard validation network future under exit signal (paritytech#168) * bump version to v0.3.15: substrate v0.10 * [v0.3] update to substrate master (paritytech#175) * update to substrate master * fix test * service: fix telemetry endpoints on alexander chainspec (paritytech#169) (paritytech#178) * Update v0.3 to latest Substrate master (paritytech#177) * update substrate v0.3 to latest master * bump spec version * update to latest master: remove fees module * update runtime blobs * bump version to 0.3.16 * replace sr25519 accountid with anysigner * bump version to v0.3.17 * Some PoC-3 GRANDPA tweaks (paritytech#181) * call on_finalise after triggering curated_grandpa change * make grandpa rounds shorter for faster finalization * use authorities when calculating duty roster (paritytech#185) * [v0.3] Update to substrate master (paritytech#183) * update to latest substrate master * bump version to 0.3.18 * update to latest substrate master * bump spec version * update runtime wasm blobs * remove current_offline_slash from chain spec * update to substrate master: bump version to v0.3.19 (paritytech#188) * update to substrate master: bump version to v0.3.19 libp2p network improvements * network: replace NodeIndex with PeerId * network: fix tests * polkadot v0.3.20 (paritytech#190) * update to substrate master: bump version to 0.3.20 * runtime: add offchain worker trait * runtime: rebuild wasm blobs * bump spec version (paritytech#191) * Fix compilation * Update version to 0.4.0 * Switch to use `polkadot-master` branch from substrate * Remove unused struct * Remove `grandpa::SyncedAuthorities` from `OnSessionChange`
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* withdrawal module init and rename some dir module * withdrawal module finish * withdrawal finish
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…Info Remove WeightInfo in pallet-offences-subspace
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Add missing license headers and add CI check * Remove log line * Remove stale todos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.